Remove use of doc(cfg(...)) and the docsrs configuration
#282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation build for the crate on docs.rs has been failing with an error that `doc(cfg(...))` is an experimental feature. Instead of fixing this, this changeset removes the only use of the feature from the `GenericTcpStream` enumeration, which is internal and does not show in documentation anyway.
|
@wolf4ood ? Can we merge? |
|
Seems ok to me |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 88.87% 88.84% -0.03%
==========================================
Files 81 81
Lines 7541 7541
==========================================
- Hits 6702 6700 -2
- Misses 839 841 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation build for the crate on docs.rs has been failing with an error that
doc(cfg(...))is an experimental feature. Instead of fixing this, this changeset removes the only use of the feature from theGenericTcpStreamenumeration, which is internal and does not show in documentation anyway.